Repository navigation
ENG3-2064: Release 2.10.7 - #1408
Merged
Merged
Conversation
Exclude quote characters from the query/fragment capture in the no-quote output-buffer regex so URL-like text inside other attribute values is not rewritten. Add ob_callback regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Exclude quote characters from the query/fragment capture in the no-quote output-buffer regex, so URL-like text inside other attribute values is not rewritten. Add ob_callback regression tests.
* ENG3-2064: Bump version to 2.10.7 * ENG3-2064: Limit @SInCE placeholder replacement to PHP and JS files GNU grep includes a file when no --include/--exclude matches unless the first such option is --include, so the trailing --include patterns did not restrict the file list and bin/release.sh and Markdown docs were rewritten. * ENG3-2064: Replace @SInCE placeholders with 2.10.7 * ENG3-2064: Pin the POT slug so make-pot does not depend on the checkout directory name * ENG3-2064: Regenerate POT for 2.10.7 * ENG3-2064: Add 2.10.7 changelog entries and upgrade notice
jacobd91
approved these changes
Oct 1, 2026
jacobd91
left a comment
jacobd91
left a comment
Contributor
There was a problem hiding this comment.
Code review
Reviewed 5df55a68 against master (c3ca682c). The head is a fast-forward of master, so the diff is exactly the 2.10.7 release commits.
- The only runtime logic change versus
masteris the Browser Cache unquoted-attribute query class inBrowserCache_Plugin.php, which now stops at'and". Verified it no longer consumes a closing quote, and that real quoted and unquotedsrcattributes still have their query strings removed. The newW3tc_Browsercache_Ob_Callback_Testpasses (3 tests, 5 assertions). - Version bumps (
Version,W3TC_VERSION,Stable tag),@sinceplaceholders, POT header, and both changelog blocks are consistent.bin/update-changelog.sh check 2.10.7reports readme.txt and changelog.txt match (14 bullets). No@since X.X.Xplaceholders remain in shipped PHP/JS. bin/update-since-versions.shandbin/make-pot.shchanges look correct.- Automated review (Bugbot) found no bugs; security review found no issues in the changed code.
One low-severity, non-blocking note: a URL-like string inside a quoted attribute that is terminated by a space before the closing quote (e.g. cite=" src=/x.css?v=1 ") can still match the unquoted-attribute pattern. It does not break the attribute boundary. Worth a follow-up test case, not a release blocker.
Acceptance
Checked out the PR head on a local single-site install:
- Plugin reports version 2.10.7.
- Authenticated admin smoke across the W3TC settings screens (dashboard, general, page cache, minify, database cache, object cache, browser cache, cache groups, CDN, user experience, extensions, PageSpeed, support, install, setup guide, about, and extension views): 22/22 HTTP 200, no fatals.
- Page Cache screen shows the new "Preload the sitemap once" option.
- General Settings save succeeded ("Plugin configuration successfully updated.") with cache enablement and engines unchanged.
- Empty All Caches succeeded (
flush_all). - Frontend and
/wp-json/return HTTP 200.
CI is green on this head. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://imh-internal.atlassian.net/browse/ENG3-2064
Summary
secops/master(5df55a68) into publicmasterfor the 2.10.7 patch release. The head is a fast-forward of publicmaster(c3ca682c), so this PR carries exactly the commits merged on secops since2.10.6, including the reviewed and accepted release PR (BoldGrid/w3-total-cache-secops#52).Version,W3TC_VERSION, and the readmeStable tagto 2.10.7; replace@since X.X.Xplaceholders; regeneratelanguages/w3-total-cache.pot.readme.txtandchangelog.txt, plus the readme Upgrade Notice.bin/update-since-versions.shrestricts replacement to*.php/*.js(GNU grep only honors--includeas a filter when it precedes--exclude), andbin/make-pot.shpins--slug=w3-total-cacheso the POT header does not depend on the checkout directory name.Changelog (2.10.7)
Test plan
git merge-base --is-ancestor origin/master secops/masterpasses; diff vsmasteris the expected 29 files with no CI/config-only changesbin/update-changelog.sh check 2.10.7— readme.txt and changelog.txt match (14 bullets)@since X.X.X/'X.X.X'placeholders remain in shipped PHP/JS2.10.7and publish via the Travis / wordpress-tag-sync build